Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include sparse-checkouts in fake runner with git clone #986

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: include sparse-checkouts in fake runner with git clone #986

wants to merge 1 commit into from

Conversation

GavinPJK
Copy link
Contributor

@GavinPJK GavinPJK commented Nov 7, 2024

NewFakeRunnerWithGitClone uses default command runner for git sparse-checkout ... and git checkout for local testing

@jenkins-x-bot
Copy link
Contributor

Hi @GavinPJK. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garethjevans
You can assign the PR to them by writing /assign @garethjevans in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GavinPJK GavinPJK changed the title chore: include sparse-checkout in fake runner w. git clone chore: include sparse-checkouts in fake runner with git clone Nov 7, 2024
@GavinPJK
Copy link
Contributor Author

GavinPJK commented Nov 7, 2024

/cc @Skisocks @msvticket

msvticket
msvticket requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of NewFakeRunnerWithGitClone needs to be updated

pkg/fakerunners/git_cloner.go
Comment on lines +12 to +13
if command.Name == "git" && len(command.Args) > 1 {
if command.Args[0] == "clone" || command.Args[0] == "sparse-checkout" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you split up the condition into two if statement?

@msvticket
Copy link
Contributor

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvticket msvticket msvticket requested changes

@Skisocks Skisocks Awaiting requested review from Skisocks

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GavinPJK @jenkins-x-bot @msvticket